Fix compile warnings and credo #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjhaid I ran credo locally and fixed about a dozen issues, but ebert didn't show anything fixed. I'm wondering if something is broken there. |
bjhaid
reviewed
Nov 29, 2018
| @@ -138,7 +140,7 @@ defmodule KafkaEx.Protocol.CreateTopics do | |||
| end | |||
|
|
|||
| @spec parse_response(binary, integer) :: [] | Response.t | |||
| def parse_response(message, api_version) | |||
| #def parse_response(message, api_version) | |||
There was a problem hiding this comment.
I meant to actually remove that since it wasn't needed. Removing
I think ebert may be having issues:
you should be able to login to ebert since you are an admin on this project. |
|
Yeah, I saw that ebert error, but I have no idea what to do about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in prep for releasing 0.9.0